fix(pyth-lazer-puiblisher-sdk): Add Deployment Script #2587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Skipped Deployments
|
darunrs
force-pushed
the
fix-publisher-sdk-deployment
branch
from
494f9fb to
4d5694e
Compare
merolish
reviewed
Apr 16, 2025
Riateche
requested changes
Apr 17, 2025
darunrs
force-pushed
the
fix-publisher-sdk-deployment
branch
from
46196f3 to
631c72b
Compare
Riateche
reviewed
Apr 21, 2025
Riateche
approved these changes
Apr 21, 2025
darunrs
force-pushed
the
fix-publisher-sdk-deployment
branch
from
dc8183a to
066127c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cargo publish only includes files within the folder containing the Cargo.toml file for the package being published. This means the proto files are not included. As packaging collects files first before building, the normal build process will not work.
As a result, a specialized build script is needed to coerce the files in such a way that they can be published without impacting library usage.
I added a build script which will build the package first and then copy/modify files in such a way that they can be published without issue. This ensures local builds work as well as maintianing the dependency on the external proto files.
Rationale
Publishing the SDK was not working with cargo publish.
How has this been tested?
Ran the script locally. Now I need to run it in the CI to see if that works.