feat(staking): add devnet switch to wallet tester #2589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
cprussin
deleted the
cprussin/add-network-selector-to-wallet-tester-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a network switch to the wallet tester.
Rationale
We have an MDP who would like to run through the wallet test using a devnet fireblocks workspace. However, it seems that the way walletconnect or fireblocks works prevents even connecting in the wrong network (other wallets will let you connect and switch networks after connecting).
To unblock this user, I'm adding a network switch so they can switch to testnet before connecting their wallet. I'm only adding it in the wallet tester although probably it makes sense to eventually replace the wallet connect modal from
@solana/wallet-adapterwith a custom one so we can offer this option anywhere that the wallet connection UI flow shows up instead.How has this been tested?