Skip to content

feat(hermes-server) Add ignore_invalid_price_ids flag to hermes ws endpoint #2599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bplatak merged 1 commit into from
Apr 23, 2025
Merged

feat(hermes-server) Add ignore_invalid_price_ids flag to hermes ws endpoint #2599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 25 additions & 7 deletions apps/hermes/server/src/api/ws.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,8 @@ enum ClientMessage {
binary: bool,
#[serde(default)]
allow_out_of_order: bool,
#[serde(default)]
ignore_invalid_price_ids: bool,
},
#[serde(rename = "unsubscribe")]
Unsubscribe { ids: Vec<PriceIdInput> },
Expand Down Expand Up @@ -530,18 +532,22 @@ where
verbose,
binary,
allow_out_of_order,
ignore_invalid_price_ids,
}) => {
let price_ids: Vec<PriceIdentifier> = ids.into_iter().map(|id| id.into()).collect();
let available_price_ids = Aggregates::get_price_feed_ids(&*self.state).await;

let not_found_price_ids: Vec<&PriceIdentifier> = price_ids
let (found_price_ids, not_found_price_ids): (
Vec<&PriceIdentifier>,
Vec<&PriceIdentifier>,
) = price_ids
.iter()
.filter(|price_id| !available_price_ids.contains(price_id))
.collect();
.partition(|price_id| available_price_ids.contains(price_id));

// If there is a single price id that is not found, we don't subscribe to any of the
// asked correct price feed ids and return an error to be more explicit and clear.
if !not_found_price_ids.is_empty() {
// asked correct price feed ids and return an error to be more explicit and clear,
// unless the client explicitly asked to ignore invalid ids
if !not_found_price_ids.is_empty() && !ignore_invalid_price_ids {
self.sender
.send(
serde_json::to_string(&ServerMessage::Response(
Expand All @@ -556,10 +562,22 @@ where
)
.await?;
return Ok(());
} else if found_price_ids.is_empty() {
self.sender
.send(
serde_json::to_string(&ServerMessage::Response(
ServerResponseMessage::Err {
error: "No price feeds available".to_string(),
},
))?
.into(),
)
.await?;
return Ok(());
} else {
for price_id in price_ids {
for price_id in found_price_ids {
Copy link
Contributor

@merolish merolish Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not worth warn logging any not found ids, I assume.

Copy link
Collaborator

@ali-behjati ali-behjati Apr 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not a warn for us, but maybe an warn message to the client would be good (as an error response). not necessary though.

self.price_feeds_with_config.insert(
price_id,
*price_id,
PriceFeedClientConfig {
verbose,
binary,
Expand Down
Loading