feat(pulse-scheduler): optimize gas when querying active subscriptions #2604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Skipped Deployments
|
ali-behjati
approved these changes
Apr 23, 2025
jayantk
approved these changes
Apr 23, 2025
| _state.activeSubscriptionIds.push(subscriptionId); | ||
| _state.activeSubscriptionIndex[subscriptionId] = _state | ||
| .activeSubscriptionIds | ||
| .length; |
There was a problem hiding this comment.
maybe leave a comment here noting that this array is 1-indexed. I thought this was a bug until i looked further
that said, is there a test that adds & removes a bunch of subscriptions to validate that this logic works?
There was a problem hiding this comment.
Yep, the 1-based indexing is documented in other places, but it's definitely not intuitive so i'll mention it every place the map is directly used
There are tests that cover adding and removing subscriptions, and the gas benchmark adds and removes hundreds. I'll augment the existing unit tests to stress test the implementation some more.
tejasbadadare
deleted the
tb/pulse-scheduler/optimize-gas-active-subscriptions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Optimize gas usage when querying for all active subscriptions.
Rationale
This is one the most frequent access patterns in scheduler, since keepers need to poll the set of active subscriptions periodically to keep their state consistent. It's a view function so it will just be simulated, but since we could potentially store thousands of subscriptions, we still want to make it efficient.
This optimization sacrifices a bit of gas when activating/deactivating subscriptions (which should be relatively uncommon), for efficiency gains in the
getActiveSubscriptionsfunction. Previously we needed to iterate through all subscriptions to collect the active ones. This doesn't scale well as more subscriptions get deactivated.Now, we store the active subscriptions in an
activeSubscriptionIdsarray for efficient querying and paging, and store a map ofsub id -> index in activeSubscriptionIdsfor efficient removal when deactivating subscriptions.How has this been tested?
Gas benchmark results