refactor(pulse): rename Pulse → Echo and PulseScheduler → Pulse #2606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Skipped Deployments
|
tejasbadadare
changed the title
jayantk
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Rationale
Pulse has two distinct functionalities: the scheduler component (under active development) and the delayed execution aka "request & fulfill" component (on hold for now).
Chatted with Ali on this topic, and it feels confusing to have both products share the same name since they are not really related to each other. It's ambiguous what's being referred to when someone talks about Pulse, both internally and externally.
Furthermore, the name "Pulse" makes more sense when referring to a scheduler (updating feeds on a heartbeat, keeping a finger on the pulse.)
Thus, in this PR, we rename the Pulse Scheduler product to inherit the name Pulse -- we'll refer to it simply as Pulse going forward.
We also give the request & fulfill product the (temporary) name Echo, I think it fits the product well (receiving a call back at a later time.) But this is just an idea, keen to hear other people's opinions :) another idea I had for the name was Chronos, the Greek god of time, fitting in with our Greek mythology theme.
TLDR - to make naming more consistent:
Implementation details
target_chains/ethereum/contracts/contracts/pulsetotarget_chains/ethereum/contracts/contracts/echotarget_chains/ethereum/contracts/contracts/pulse/schedulertotarget_chains/ethereum/contracts/contracts/pulseIScheduler.sol) to avoid confusion in the git history, and it should be okay to keep the user facing contracts named Scheduler. But we can change this to Pulse as well if we want.How has this been tested?