fix(entropy): Use the block number of event instead of request data for revelation api #2607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
jayantk
reviewed
Apr 23, 2025
Contributor
jayantk
left a comment
jayantk
left a comment
There was a problem hiding this comment.
I think this introduces a fairly awkward API -- see inline comment for a suggestion on a better way
apps/fortuna/src/api/revelation.rs
Outdated
| #[utoipa::path( | ||
| get, | ||
| path = "/v1/chains/{chain_id}/revelations/{sequence}", | ||
| path = "/v1/chains/{chain_id}/revelations/{block_number}/{sequence}", |
Contributor
There was a problem hiding this comment.
this is a very awkward API for someone to call -- how would they know to get the block number also?
I think a better solution is to implement the cache of events for the explorer, and then use that to do the lookup from sequence number to block number.
m30m
changed the title
m30m
force-pushed
the
block-based-revelation
branch
from
56bf530 to
d2df7bb
Compare
jayantk
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve revelations api for arbitrum based chains
Rationale
Current revelations api doesn't work well where
block.numberon-chain is different from what rpc returns. In arbitrum based chains, one points to the L1 block and the other to the L2 block.How has this been tested?