fix(entropy): Fix Event definitions to maintain backward compatibility #2616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
m30m
approved these changes
Apr 24, 2025
| address provider, | ||
| uint64 sequenceNumber | ||
| ) external view returns (EntropyStructs.Request memory req); | ||
| ) external view returns (EntropyStructsV2.Request memory req); |
Contributor
There was a problem hiding this comment.
can you check if the current fortuna deserializes this correctly?
tejasbadadare
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bring back the original EntropyStructs definitions and move the new structs to EntropyStructsV2. Use the old EntropyStructs in events to maintain the selectors.
Rationale
The last few Entropy PRs have added fields to the contract structs, which were backward compatible with the storage. However, these changes change the selectors of Events, which breaks the public interface of the contract that is used by Fortuna to identify requests. This PR fixes the public interface so the selectors aren't changed.
How has this been tested?
I checked out an old version of the code and computed selectors using
forge selectors listthen compared with the new version.