fix(pulse): remove priceIds parameter from updatePriceFeeds #2636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tejasbadadare
changed the title
ali-behjati
approved these changes
Apr 30, 2025
tejasbadadare
deleted the
tb/pulse/remove-priceids-from-updatepricefeeds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove unnecessary
priceIdsparameter fromupdatePriceFeedsRationale
The
updatePriceFeedsfunction takes updateData and priceIds from the Keeper, and verifies that the provided priceIds match the subscription’s priceIds. However, this isn't necessary as we can use the subscription param's priceIds list, and the thePyth.parsePriceFeedUpdatesWithSlotscall validates that the updateData contains the desired priceIds.If updateData contains any extra prices not matching the provided priceIds, they will be skipped and will not appear in the result, and if updateData doesn't contain enough prices for the subscription's feeds, it will revert with
PythErrors.PriceFeedNotFoundWithinRange()How has this been tested?