Skip to content

Conversation

ndiakom
Copy link
Contributor

@ndiakom ndiakom commented Apr 30, 2025

Summary

Adding Anton's and Mario's names to list of signers, following the DAO confirming the composition of the 3rd iteration of the Price Feed Council.

Rationale

To easily identify proposal voters, as is currently done for existing signers.

How has this been tested?

  • Current tests cover my changes
  • Added new tests
  • Manually tested the code

Checked the JSON structure visually and verified correctness of the information taken from forum submissions of the candidates that won (Anton and Mario).

Copy link

vercel bot commented Apr 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
entropy-debugger ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2025 1:30pm
insights ❌ Failed (Inspect) Apr 30, 2025 1:30pm
proposals ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2025 1:30pm
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2025 1:30pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Apr 30, 2025 1:30pm
component-library ⬜️ Ignored (Inspect) Apr 30, 2025 1:30pm

@ndiakom ndiakom changed the title Adding Anton and Mario's names New PF Council signers: Anton and Mario Apr 30, 2025
@ndiakom
Copy link
Contributor Author

ndiakom commented Apr 30, 2025

Not changing anything related to IH but the check is failing. Not sure what to do.
@cprussin

@cprussin
Copy link
Collaborator

@ndiakom the failure on IH build is related to a change on the onchain metadata that doesn't match the schema expectations; this has nothing to do with your PR so you can safely merge this and ignore the failure

@ndiakom ndiakom merged commit 583a098 into main Apr 30, 2025
9 of 10 checks passed
@ndiakom ndiakom deleted the pf_council_3_new_signers branch April 30, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants