chore(component-library): extract app shell from insights hub #2650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This PR makes a few related changes: - Extract the app shell from insights hub to component library - Merge `next-root`, `app-logger`, and `fonts` into the component library (the separation here didn't end up to be as clean as I'd originally hoped) - Fix storybook and handle dark/light mode and primary/secondary backgrounds more correctly
cprussin
force-pushed
the
cprussin/extract-app-shell
branch
from
f827a1d to
8efb316
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes a few related changes:
next-root,app-logger, andfontsinto the component library (the separation here didn't end up to be as clean as I'd originally hoped)Rationale
I have a few new apps that I'm going to build next week and I'll want to share a consistent app shell
How has this been tested?