feat(pulse): add maximum deposit limit for permanent subscriptions #2675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Tejas Badadare <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Tejas Badadare <[email protected]>
Comment on lines
531
to
546
| SubscriptionParams storage params = _state.subscriptionParams[ | ||
| subscriptionId | ||
| ]; | ||
| SubscriptionStatus storage status = _state.subscriptionStatuses[ | ||
| subscriptionId | ||
| ]; | ||
|
|
||
| // Check deposit limit for permanent subscriptions | ||
| if ( | ||
| params.isPermanent && | ||
| status.balanceInWei + msg.value > MAX_DEPOSIT_LIMIT | ||
| ) { | ||
| revert MaxDepositLimitExceeded(); | ||
| } | ||
|
|
||
| status.balanceInWei += msg.value; |
There was a problem hiding this comment.
The check should be on the incoming deposit, not on the balance
Co-Authored-By: Tejas Badadare <[email protected]>
devin-ai-integration
bot
force-pushed
the
devin/1747072255-add-max-deposit-limit-for-permanent-subscriptions
branch
from
2ee0169 to
422dca8
Compare
| subscriptionId | ||
| ]; | ||
|
|
||
| if (!status.isActive) { |
There was a problem hiding this comment.
This should be if (!params.isActive)
Co-Authored-By: Tejas Badadare <[email protected]>
Co-Authored-By: Tejas Badadare <[email protected]>
3 tasks
|
Closing due to inactivity for more than 7 days. |
ali-behjati
approved these changes
May 27, 2025
tejasbadadare
deleted the
devin/1747072255-add-max-deposit-limit-for-permanent-subscriptions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Maximum Deposit Limit for Permanent Subscriptions
This PR implements a maximum deposit limit for permanent subscriptions in the Pulse contract to mitigate the risk of accidental over-deposits.
Changes
MAX_DEPOSIT_LIMITconstant inSchedulerState.solset to 100 ETHMaxDepositLimitExceedederror inSchedulerErrors.solcreateSubscriptioninScheduler.solto check deposit limit for permanent subscriptionsaddFundsinScheduler.solto check deposit limit for permanent subscriptionsPulseScheduler.t.solto verify deposit limit functionalityTesting
All tests have been run and pass successfully, including new tests for the deposit limit functionality.
Link to Devin run
https://app.devin.ai/sessions/feae11c6c0db4a739a42be4fe136f996
Requested by
Tejas Badadare ([email protected])