test(pulse): add tests for price updates removal and max price IDs validation #2676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Tejas Badadare <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
tejasbadadare
changed the title
Co-Authored-By: Tejas Badadare <[email protected]>
3 tasks
|
Closing due to inactivity for more than 7 days. |
ali-behjati
reviewed
May 27, 2025
There was a problem hiding this comment.
Devin please fix my comments.
@tejasbadadare you can approve and merge it when it fixes the tests
| ); | ||
|
|
||
| // - Verify that the removed price ID is not included in the returned prices | ||
| for (uint i = 0; i < allPricesAfterUpdate.length; i++) { |
There was a problem hiding this comment.
this for is unnecessary, but why we cannot check all the priceIds directly? Does the order change?
| allPricesAfterUpdate.length, | ||
| updatedParams.priceIds.length, | ||
| "Number of returned prices should match number of price IDs in subscription" | ||
| ); |
There was a problem hiding this comment.
can we also test the behaviour of getting the price of the removed feed?
Co-Authored-By: Tejas Badadare <[email protected]>
…evin/1747075585-add-pulse-scheduler-tests
tejasbadadare
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for PulseScheduler
This PR adds two new test cases to the PulseScheduler test suite:
testUpdateSubscriptionRemovesPriceUpdatesForRemovedPriceIds()- Verifies that after updating a subscription's price IDs list, thepriceUpdatesmapping no longer contains price data for removed price IDs.testUpdateSubscriptionRevertsWithTooManyPriceIds()- Asserts thatupdateSubscriptionreverts ifpriceIds.length > MAX_PRICE_IDS_PER_SUBSCRIPTION.Both tests pass when run with forge test and the code passes linting checks.
Link to Devin run: https://app.devin.ai/sessions/01e1cd793ef8465090357079505e07c0
Requested by: Tejas Badadare