feat(entropy): Better tester contract #2679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
m30m
approved these changes
May 12, 2025
| ) public payable returns (uint64 sequenceNumber) { | ||
| requireGasUsageAboveLimit(callbackGasUsage); | ||
|
|
||
| IEntropy entropy = IEntropy(address(getEntropyWithDefault(_entropy))); |
There was a problem hiding this comment.
this looks a bit awkward. Maybe make getEntropyWithDefault just return the address?
| * @notice Ensures the gas usage is above the minimum required limit | ||
| * @param gasUsage The gas usage to check | ||
| */ | ||
| function requireGasUsageAboveLimit(uint32 gasUsage) internal pure { |
There was a problem hiding this comment.
what's this? we are not storing callback results in this contract 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the EntropyTester contract to support both the v1 and v2 request flows, as well as more configurable callback conditions.
Rationale
These changes will help us test entropy deployments more thoroughly.
How has this been tested?