-
Notifications
You must be signed in to change notification settings - Fork 301
chore: add panic-related clippy lints to fortuna #2688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
devin-ai-integration
wants to merge
3
commits into
main
from
devin/1747321472-fortuna-clippy-panic-lints
Closed
chore: add panic-related clippy lints to fortuna #2688
devin-ai-integration
wants to merge
3
commits into
main
from
devin/1747321472-fortuna-clippy-panic-lints
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Jayant Krishnamurthy <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Jayant Krishnamurthy <[email protected]>
Co-Authored-By: Jayant Krishnamurthy <[email protected]>
|
Closing due to inactivity for more than 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add panic-related clippy lints to fortuna
This PR adds a
[lints.clippy]section to the fortuna Cargo.toml file to deny clippy lint rules that guard against panics. This helps prevent potential runtime panics in the codebase.Specifically, the following panic-related lints are denied:
Note on Implementation
Running the pre-commit hooks with these lints enabled shows over 65 lint errors in the codebase. Fixing all of these would require significant refactoring, including:
.unwrap()and.expect()calls with proper error handling.get()or.get_mut()to avoid potential panicsTest Configuration
Note that these lints will also apply to test code. To exclude tests from these lint rules, code-level attributes should be used in test modules or functions:
As requested, I've added the lints but have not made the extensive code changes required to fix all the errors.
Link to Devin run: https://app.devin.ai/sessions/7628ce4c804a45eea59d57847ac320d3
Requested by: Jayant Krishnamurthy