feat(fortuna): Add clippy lint attributes to warn about panic-causing lints #2689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=80&v=4){kind=small}
… lints Co-Authored-By: Jayant Krishnamurthy <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Jayant Krishnamurthy <[email protected]>
Co-Authored-By: Jayant Krishnamurthy <[email protected]>
Co-Authored-By: Jayant Krishnamurthy <[email protected]>
|
Closing due to inactivity for more than 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add clippy lint attributes to deny panic-causing lints in Fortuna
Description
This PR adds Clippy lint attributes to the Fortuna codebase to warn about any Clippy lint rules that guard against panics. These lint rules are configured to apply to the default target but not to tests.
The following panic-related lints are configured:
expect_used: Warns on usage of.expect()which can panicunwrap_used: Warns on usage of.unwrap()which can panicpanic: Warns on usage ofpanic!()macrounimplemented: Warns on usage ofunimplemented!()macrounreachable: Warns on usage ofunreachable!()macroindexing_slicing: Warns on indexing/slicing operations that can panicpanic_in_result_fn: Warns on panicking in functions that returnResulttodo: Warns on usage oftodo!()macroThese lints will help prevent introducing new code that could panic in production environments, while still allowing these constructs in test code.
Testing
cargo checkRequested by: Jayant Krishnamurthy
Link to Devin run: https://app.devin.ai/sessions/da25c6851cda4d17949abae63093a4e0