test(fortuna): add unit tests for eth_gas_oracle functions #2699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Jayant Krishnamurthy <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
jayantk
reviewed
May 16, 2025
| assert_eq!( | ||
| max_priority_fee, | ||
| U256::from(EIP1559_FEE_ESTIMATION_DEFAULT_PRIORITY_FEE) | ||
| ); |
There was a problem hiding this comment.
please add a test for the case where max_priority_fee is computed using estimate_priority_fee
…riority_fee Co-Authored-By: Jayant Krishnamurthy <[email protected]>
Co-Authored-By: Jayant Krishnamurthy <[email protected]>
m30m
approved these changes
May 18, 2025
|
Closing due to inactivity for more than 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests for Fortuna's gas oracle functions
This PR adds unit tests for two gas oracle functions in Fortuna:
estimate_priority_feefunction that calculates priority fees from reward dataeip1559_default_estimatorfunction that calculates max fee and priority feeTests added:
Link to Devin run: https://app.devin.ai/sessions/83a15de209384e5db56d9851213ba148
Requested by: Jayant Krishnamurthy ([email protected])