feat(pyth-lazer-publisher-sdk): Add Public key to Transactions #2700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Riateche
approved these changes
May 19, 2025
Comment on lines
-22
to
+19
| optional bytes payload = 3; | ||
| optional bytes payload = 2; |
Contributor
There was a problem hiding this comment.
for my information, what is the side effect of changing these numbers?
Contributor
There was a problem hiding this comment.
It changes the wire format so once the protocol is in use we should never change it. While we're prototyping it doesn't really matter.
keyvankhademi
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds public key to transacitons. Expanded signature format to support a much greater set of possible signatures.
Rationale
We are eliminating access tokens in pyth lazer so we need publishers to send public keys to establish identity.
How has this been tested?