-
Notifications
You must be signed in to change notification settings - Fork 306
feat(lazer) Add GovernanceInstructionContext to transaction_envelope.proto #2720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| // Context contains status of each governance instruction found in transaction | ||
| message GovernanceInstructionContext { | ||
| // [required] ID of publisher based on the access token used to connect | ||
| optional uint32 publisher_id = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
publisher doesn't make sense in this context I think.
@darunrs ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really no
| // [required] the governance instruction | ||
| GovernanceInstruction governance_instruction = 2; | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Add a new payload context for TransactionEnvelope to represent governance insutructions.
Rationale
The Lazer transactions are used to convey both publisher updates as well as governance actions
How has this been tested?