feat(fortuna): add result count to results #2760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
m30m
approved these changes
Jun 5, 2025
apps/fortuna/src/history.rs
Outdated
| query_builder.build_query_as().fetch_all(self.pool).await; | ||
|
|
||
| if let Err(e) = &result { | ||
| tracing::error!("Failed to fetch request by time: {}", e); |
There was a problem hiding this comment.
I think by time here remained from the old functions. Let's remove it
This is necessary so we can implement a paginator on the UI since we need to know how many pages there are (or at the very least, we need to know if there's a next page).
cprussin
force-pushed
the
cprussin/add-result-count-to-fortuna-log
branch
from
55c9f5d to
8709cdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a total result count field to the fortuna logs response
Rationale
This is necessary so we can implement a paginator on the UI since we need to know how many pages there are (or at the very least, we need to know if there's a next page).
How has this been tested?