feat(fortuna): add prometheus metrics for history query latency #2761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cprussin
commented
Jun 6, 2025
| futures = { version = "0.3.28" } | ||
| hex = "0.4.3" | ||
| prometheus-client = { version = "0.21.2" } | ||
| prometheus-client = { version = "0.23.1" } |
There was a problem hiding this comment.
This upgrade is required because in 0.21.2 there was no implementation of the EncodeLabelSet trait for bool, which I need
cprussin
commented
Jun 6, 2025
m30m
approved these changes
Jun 6, 2025
cprussin
force-pushed
the
cprussin/measure-timings-for-history-queries
branch
from
f0596c2 to
12c0944
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add prometheus histograms to measure query latency for explorer queries.
Rationale
So that we can keep an eye on query performance in prod.
How has this been tested?