feat(entropy-tester): add docker image workflow #2772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cprussin
approved these changes
Jun 10, 2025
cprussin
reviewed
Jun 10, 2025
Comment on lines
+13
to
+16
| dispatch_description: | ||
| description: "Dispatch description" | ||
| required: true | ||
| type: string |
There was a problem hiding this comment.
Why is this argument here?
There was a problem hiding this comment.
I copy pasted it from other configs. I believe it is for manual dispatch of the job which can be useful 🤔
There was a problem hiding this comment.
I don't think you need the inputs, I think you just need workflow_dispatch with no children. The inputs creates a UI where you can fill in values when doing the manual dispatch, but you aren't actually using the input anywhere so I think it should be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To be used in deployments
How has this been tested?