Add tests for quorum #2791
Merged
Add tests for quorum #2791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds scaffolding for unit tests in the quorum server and updates the crate version.
- Bumps crate version to 0.1.3
- Introduces a new
testsmodule inserver.rswith aget_statehelper
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/quorum/src/server.rs | Adds #[cfg(test)] mod tests with a get_state helper for constructing State |
| apps/quorum/Cargo.toml | Updates version from 0.1.2 to 0.1.3 |
Comments suppressed due to low confidence (2)
apps/quorum/src/server.rs:133
- The test module currently only defines a helper (
get_state) but lacks any actual test cases. Consider adding unit tests that leverage this helper to validate core quorum behaviors.
pub mod tests {
apps/quorum/src/server.rs:136
- [nitpick] This helper manually constructs
StateInner. You might implementDefaultor a builder forState/StateInnerto reduce boilerplate in tests and make future updates easier.
pub fn get_state(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add tests for Pyth quorum