Quorum: Add metrics over http urls #2804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danimhr
changed the title
ali-behjati
reviewed
Jun 24, 2025
apps/quorum/src/server.rs
Outdated
|
|
||
| pub async fn wait_for_exit() { | ||
| let mut rx = EXIT.subscribe(); | ||
| if !*rx.borrow() { |
There was a problem hiding this comment.
can you add a bit of comment here? or maybe change it to if *rx.borrow == false?
There was a problem hiding this comment.
using *rx.borrow == false would cause some lint issues. Added some comments
ali-behjati
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.