Hermes: Add error log when receiving invalid quorum VAA #2810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ali-behjati
approved these changes
Jun 26, 2025
| @@ -512,7 +512,7 @@ where | |||
| let state = state.clone(); | |||
| async move { | |||
| if let Err(e) = state.process_message(vaa_bytes).await { | |||
| tracing::debug!(error = ?e, "Skipped VAA."); | |||
| tracing::error!(error = ?e, "Received an invalid VAA from PythNet quorum."); | |||
There was a problem hiding this comment.
I didn't notice quorum is in Pythnet module. Would it be possible to move it out? (not necessary as this code is not gonna change but it's nicer).
There was a problem hiding this comment.
Let me create a new PR for this
Where should I put it?
ali-behjati
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add error logs if the VAA received by PythNet quorum service was invalid.