Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jul 1, 2025

Summary

  • Enable automated fair fee withdrawals with multiple keepers.
    • This is done by allowing independent configuration of the fee manager private key and the keeper private key. This allows multiple keepers to have different keeper wallets, but share the fee manager wallet. Each keeper will withdraw fees from the contract as the fee manager and transfer into its own keeper wallet as needed.
    • Each keeper tracks the balance of other known_keeper_addresses. When below min_balance, a keeper will try to withdraw up to (T/N) where T is the total fees across all keepers and the contract, and N is the number of keepers.
  • Remove the disable_fee_withdrawal run config, since this is no longer required with this change.
  • Update documentation and sample configs

Test plan

  • Test locally
  • Deploy to testnet with 2+ replicas, trigger fee withdrawals, verify funds transfer correctly to individual keeper wallets while using shared fee manager key.

…ica support

- Add fee_manager_private_key to KeeperConfig for fee manager operations
- Add known_keeper_addresses for balance comparison
- Modify withdrawal logic to use fee manager key for fee manager calls
- Only withdraw fees if current keeper has lowest balance among known keepers
- Maintain backward compatibility with existing single-key setup

Co-Authored-By: Tejas Badadare <[email protected]>
@devin-ai-integration
Copy link
Contributor Author

devin-ai-integration bot commented Jul 1, 2025

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@vercel
Copy link

vercel bot commented Jul 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2025 11:28pm
component-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2025 11:28pm
developer-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2025 11:28pm
entropy-debugger ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2025 11:28pm
entropy-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2025 11:28pm
insights ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2025 11:28pm
proposals ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2025 11:28pm
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2025 11:28pm

Copy link
Contributor

@tejasbadadare tejasbadadare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR description with the updated implementation details.

@tejasbadadare
Copy link
Contributor

Simplified things by using a contract with the fee manager as the signer throughout the fee management functions. This helps because only the fee manager can execute the on-chain fee functions anyway. This way we don't have to juggle a contract with a keeper signer, fee manager wallets, providers, etc.

Copy link
Contributor

@jayantk jayantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

…evin/1751328352-separate-fee-manager-keeper-wallets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants