fix(fortuna): Fix nonce increment issues on high usage chains #2868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jayantk
commented
Jul 18, 2025
| match self { | ||
| SubmitTxError::GasUsageEstimateError(e) => { | ||
| write!(f, "Error estimating gas for reveal: {e:?}") | ||
| SubmitTxError::GasUsageEstimateError(tx, e) => { |
There was a problem hiding this comment.
drive-by for easier debugging
tejasbadadare
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are seeing high latency on blast responses. After investigating, @tejasbadadare and I determined that the root cause is that we are incorrectly incrementing the local nonce on occasions where we do not send the transaction to the RPC. This specifically happens when a transaction reverts -- we are incrementing the nonce before identifying that the tx reverts.
This PR adds an estimate_gas call to catch reverts prior to filling the nonce in the transaction.
How has this been tested?