Skip to content

fix(hermes): Update Hermes API Response to No Context #2919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(hermes): Update Hermes API Response to No Context #2919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/hermes/server/src/api/rest.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@ impl IntoResponse for RestError {
fn into_response(self) -> Response {
match self {
RestError::BenchmarkPriceNotUnique => {
(StatusCode::NOT_FOUND, "Benchmark price is not unique").into_response()
(StatusCode::NO_CONTENT, "Benchmark price is not unique").into_response()
}
RestError::UpdateDataNotFound => {
(StatusCode::NOT_FOUND, "Update data not found").into_response()
(StatusCode::NO_CONTENT, "Update data not found").into_response()
}
RestError::CcipUpdateDataNotFound => {
// Return "Bad Gateway" error because CCIP expects a 5xx error if it needs to retry
Expand All @@ -75,7 +75,7 @@ impl IntoResponse for RestError {
.join(", ");

(
StatusCode::NOT_FOUND,
StatusCode::NO_CONTENT,
format!("Price ids not found: {missing_ids}"),
)
.into_response()
Expand Down
Loading