fix: uncache getFeedScoreHistory #2965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
alexcambose
changed the title
fhqvst
approved these changes
Aug 19, 2025
Contributor
fhqvst
left a comment
fhqvst
left a comment
There was a problem hiding this comment.
Looks good! Might be worth adding a comment describing why this specific function is not cached when most (all?) other functions in here are cached
Contributor
Author
|
Fair point, will add that later |
Collaborator
|
This makes sense, I think this will also get even more significant when we add the error visualization & component feeds in the chart. Reasonable to not bother with caching. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This functions seems to have tons of params with date ranges and it's really using up a lot of redis resources. I also don't think it adds much benefit to redis cache this so removing it for now.
Rationale
How has this been tested?