feat: rounded property to toggle #2967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alexcambose
requested review from
cprussin and
fhqvst
and removed request for
a team
cprussin
reviewed
Aug 19, 2025
| )} | ||
| data-size="sm" | ||
| data-variant="ghost" | ||
| data-rounded={rounded ? true : undefined} |
Collaborator
There was a problem hiding this comment.
This should be rounded ? "" : undefined (the idea is that we want data attributes that are boolean to either be present or not, rather than have the value true, to be consistent with how react-aria does things)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Screen.Recording.2025-08-19.at.16.20.23.mov
Rationale
Added a rounded option for the toggle that will be used for the chart timeframe buttons.
How has this been tested?