feat(contracts): remove truffle and replace with foundry #2973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
nidhi-singh02
force-pushed
the
remove-truffle
branch
from
0ad7686 to
8075795
Compare
nidhi-singh02
commented
Aug 26, 2025
| @@ -1,5 +1,6 @@ | |||
| /// <reference types="next" /> | |||
| /// <reference types="next/image-types/global" /> | |||
| /// <reference path="./.next/types/routes.d.ts" /> | |||
There was a problem hiding this comment.
Through format fixing.
nidhi-singh02
commented
Aug 26, 2025
| @@ -1,5 +1,6 @@ | |||
| /// <reference types="next" /> | |||
| /// <reference types="next/image-types/global" /> | |||
| /// <reference path="./.next/types/routes.d.ts" /> | |||
There was a problem hiding this comment.
format fix as test was failing in CI
aditya520
approved these changes
Aug 26, 2025
| @@ -0,0 +1,122 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
| pragma solidity ^0.8.0; | |||
| @@ -0,0 +1,67 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
There was a problem hiding this comment.
Do we need this file as well?
| @@ -0,0 +1,70 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
| pragma solidity ^0.8.0; | |||
|
|
|||
| @@ -1,27 +1,47 @@ | |||
| # Migrations Metadata | |||
| MIGRATIONS_DIR=./migrations/test | |||
| # ============================================================================= | |||
|
As discussed on the call with Aditya, reg the deletion of the files, will proceed after getting confirmation from Ali. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This changeset removes truffle and its dependencies and replace the smart contract build, deployment and verification process to foundry.
Tasks done in this one -
As part of README.md, we had the local testing setup earlier, Kept it as is.
Tested the deployment of the wormhole contract and the pyth contract using the foundry setup we migrated to.
Tested on a virtual network I created with a custom chain ID 84520 forked from Base sepolia (EVM network).
Steps I followed to do deployment of the price feed ID contract
pyth-crosschain/contract_manager/store/chains/EvmChains.json
Line 1303 in 46fa322
{ "id": "nids_network", "mainnet": false, "rpcUrl": "my_rpc_url", "networkId": 84520, "type": "EvmChain" }nids-networkinpyth-crosschain/governance/xc_admin/packages/xc_admin_common/src/chains.ts
Line 254 in 46fa322
Command I ran
cd pyth-crosschain/target_chains/ethereum/contracts ./deploy.sh latest nids_networkAttached the deployment logs.
Note:
scriptfolder has foundry related setup.scriptsis for js/ts files. Keeping these separate for now.Enhancements that can be done-
forge-test, will replace it withtestin another PR.forge verify-contractto verify the contracts that has already been deployed.Rationale
How has this been tested?