Skip to content

Conversation

@alexcambose
Copy link
Contributor

Summary

Seems that 1 day for the cache is too long.

Rationale

How has this been tested?

  • Current tests cover my changes
  • Added new tests
  • Manually tested the code

@alexcambose alexcambose requested a review from a team as a code owner August 21, 2025 14:45
@alexcambose alexcambose requested a review from cprussin August 21, 2025 14:45
@vercel
Copy link

vercel bot commented Aug 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
component-library Ready Ready Preview Comment Aug 21, 2025 2:47pm
insights Ready Ready Preview Comment Aug 21, 2025 2:47pm
5 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
api-reference Skipped Skipped Aug 21, 2025 2:47pm
developer-hub Skipped Skipped Aug 21, 2025 2:47pm
entropy-explorer Skipped Skipped Aug 21, 2025 2:47pm
proposals Skipped Skipped Aug 21, 2025 2:47pm
staking Skipped Skipped Aug 21, 2025 2:47pm

@cprussin
Copy link
Collaborator

This could be a bit tricky since some of the endpoints are used to e.g. list pubs for a feed, which might change quite quickly. I expect this will require more tuning.

@alexcambose
Copy link
Contributor Author

yea might need to set custom TTLs for certain things, for now it's clear that setting it for 1 day for everything was way too long

@alexcambose alexcambose merged commit 01b2f80 into main Aug 21, 2025
10 checks passed
@alexcambose alexcambose deleted the feat/cache-time branch August 21, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants