feat(lazer/sui): verify signatures against trusted signers #2982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Tejas Badadare <[email protected]>
…rosschain into tb/lazer/sui-storage
Co-Authored-By: Tejas Badadare <[email protected]>
…rosschain into tb/lazer/sui-storage
…and tests; verified with Sui CLI 1.53.2 Co-Authored-By: Tejas Badadare <[email protected]>
…rosschain into tb/lazer/sui-storage
… CLI 1.53.2 Co-Authored-By: Tejas Badadare <[email protected]>
…d gate updates with admin cap Co-Authored-By: Tejas Badadare <[email protected]>
…rosschain into tb/lazer/sui-storage
…dminCapability Co-Authored-By: Tejas Badadare <[email protected]>
…er via AdminCapability" This reverts commit 187f0e9.
…_lazer::init; share State; add OTW doc comments Co-Authored-By: Tejas Badadare <[email protected]>
…rosschain into tb/lazer/sui-verify
…rosschain into tb/lazer/sui-verify
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
darunrs
approved these changes
Aug 22, 2025
merolish
reviewed
Aug 22, 2025
| use pyth_lazer::admin::{Self, AdminCap}; | ||
|
|
||
| const ED25519_PUBKEY_LEN: u64 = 32; | ||
| const SECP256K1_COMPRESSED_PUBKEY_LEN: u64 = 33; |
There was a problem hiding this comment.
Gave a more accurate name
merolish
reviewed
Aug 22, 2025
| // When we have an unknown property, we do not know its length, and therefore | ||
| // we cannot ignore it and parse the next properties. | ||
| abort 0 // FIXME: return more granular error messages | ||
| abort EInvalidUpdate // FIXME: return more granular error messages |
There was a problem hiding this comment.
Is this no longer a fixme?
There was a problem hiding this comment.
Still a FIXME since there are several other places in the parsing where the code can revert. Will be tackling this next.
merolish
approved these changes
Aug 22, 2025
ali-behjati
reviewed
Aug 25, 2025
| /// # Errors | ||
| /// * `ESignerNotTrusted` - The recovered public key is not in the trusted signers list | ||
| /// * `ESignerExpired` - The signer's certificate has expired | ||
| public fun verify_le_ecdsa_message( |
There was a problem hiding this comment.
do we need to make it public :? maybe public in crate be enough (so we can test it, but users don't use it)
There was a problem hiding this comment.
Sure, figured it might be handy for users, but yeah i can't think of a scenario where they'd wanna validate without parsing.
ali-behjati
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Verify signature against trusted signers from state.
Next up i'll break up the parse function a bit so I can add better error handling.
How has this been tested?