-
Notifications
You must be signed in to change notification settings - Fork 314
chore(dev-hub)-header Improvements #3002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
| <Button | ||
| onClick={() => { | ||
| setOpen(true); | ||
| }} | ||
| variant="outline" | ||
| size="sm" | ||
| rounded | ||
| beforeIcon={<MagnifyingGlass size={16} />} | ||
| > | ||
| Search | ||
| </Button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest putting in both variants in
pyth-crosschain/apps/insights/src/components/Root/search-button.tsx
Lines 73 to 99 in 56465a9
| const SearchButtonImpl = ( | |
| props: Omit<ButtonProps<typeof UnstyledButton>, "children">, | |
| ) => ( | |
| <div className={styles.searchButton}> | |
| <Button | |
| className={styles.largeScreenSearchButton ?? ""} | |
| variant="outline" | |
| beforeIcon={<MagnifyingGlass />} | |
| size="sm" | |
| rounded | |
| {...props} | |
| > | |
| <SearchShortcutText /> | |
| </Button> | |
| <Button | |
| className={styles.smallScreenSearchButton ?? ""} | |
| hideText | |
| variant="ghost" | |
| beforeIcon={<MagnifyingGlass />} | |
| size="sm" | |
| rounded | |
| {...props} | |
| > | |
| Search | |
| </Button> | |
| </div> | |
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
df8d497 to
44750fc
Compare
Summary
Note:
I managed to add the search in the header, but search server is not giving me any results.
Need help in fixing that.
Rationale
How has this been tested?