feat: update search on feeds table #3018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
alexcambose
requested review from
cprussin,
felix-asym and
fhqvst
and removed request for
felix-asym
fhqvst
reviewed
Sep 4, 2025
Comment on lines
+95
to
+97
| return matchSorter(items, search, { | ||
| keys: ["displaySymbol", "symbol", "description", "key"], | ||
| }); |
Contributor
There was a problem hiding this comment.
Is there any chance this call would be blocking? Perhaps the array is small enough that this isn't a problem
Contributor
Author
There was a problem hiding this comment.
it's a few thousands items so I don't think it's going to impact too much
| predicate: (item: T, term: string) => boolean, | ||
| predicate: (item: T, search: string) => boolean, | ||
| doSort: (a: T, b: T, descriptor: SortDescriptor) => number, | ||
| doMutate: (items: T[], search: string) => T[], |
Contributor
There was a problem hiding this comment.
Could probably have deleted predicate and doSort at this point since doMutate is a more open/powerful API anyway
Contributor
Author
There was a problem hiding this comment.
That's fair and I think at some point we can remove that. I didn't want to do a big refactor this time as it's used in a few places.
fhqvst
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed the search behaviour for the price feeds card/search box to match the one in the search bar.
Rationale
How has this been tested?