-
Notifications
You must be signed in to change notification settings - Fork 300
fix(dev hub): ui fixes #3050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dev hub): ui fixes #3050
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
.table { | ||
overflow-x: auto; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -301,7 +301,7 @@ | |
var(--color-steel-900), | ||
var(--color-steel-50) | ||
); | ||
--color-fd-muted: light-dark(var(--color-steel-100), var(--color-steel-700)); | ||
--color-fd-muted: light-dark(var(--color-steel-50), var(--color-steel-900)); | ||
--color-fd-muted-foreground: light-dark( | ||
var(--color-steel-600), | ||
var(--color-steel-400) | ||
|
@@ -336,7 +336,7 @@ | |
} | ||
|
||
/* Global typography: tighten line spacing in docs content */ | ||
:where(.prose) { | ||
.prose { | ||
line-height: 1.5; | ||
} | ||
|
||
|
@@ -347,3 +347,14 @@ | |
:where(.prose) :where(h1, h2, h3, h4, h5, h6) { | ||
line-height: 1.2; | ||
} | ||
|
||
.prose p + ul, | ||
.prose p + ol { | ||
|
||
margin-top: 0; | ||
padding-top: 0.25rem; | ||
} | ||
|
||
.prose p:has(+ ul), | ||
.prose p:has(+ ol) { | ||
margin-bottom: 0; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,36 +30,52 @@ type Tab = ComponentProps<typeof MainNavTabs>["tabs"][number] & { | |
children: ReactNode; | ||
}; | ||
|
||
type Props = AppBodyProps & { | ||
type AppShellRootProps = { | ||
enableAccessibilityReporting: boolean; | ||
amplitudeApiKey?: string | undefined; | ||
googleAnalyticsId?: string | undefined; | ||
providers?: ComponentProps<typeof ComposeProviders>["providers"] | undefined; | ||
children: ReactNode; | ||
}; | ||
|
||
export const AppShell = ({ | ||
export const AppShellRoot = ({ | ||
enableAccessibilityReporting, | ||
amplitudeApiKey, | ||
googleAnalyticsId, | ||
providers, | ||
...props | ||
}: Props) => ( | ||
children, | ||
}: AppShellRootProps) => ( | ||
<RootProviders providers={providers}> | ||
<HtmlWithLang | ||
// See https://github.com/pacocoursey/next-themes?tab=readme-ov-file#with-app | ||
suppressHydrationWarning | ||
className={clsx(sans.className, styles.html)} | ||
> | ||
<body className={styles.body}> | ||
<AppBody {...props} /> | ||
</body> | ||
<body className={styles.body}>{children}</body> | ||
{googleAnalyticsId && <GoogleAnalytics gaId={googleAnalyticsId} />} | ||
{amplitudeApiKey && <Amplitude apiKey={amplitudeApiKey} />} | ||
{enableAccessibilityReporting && <ReportAccessibility />} | ||
</HtmlWithLang> | ||
</RootProviders> | ||
); | ||
|
||
export const AppShell = ({ | ||
enableAccessibilityReporting, | ||
amplitudeApiKey, | ||
googleAnalyticsId, | ||
providers, | ||
...props | ||
}: AppShellRootProps & AppBodyProps) => ( | ||
<AppShellRoot | ||
enableAccessibilityReporting={enableAccessibilityReporting} | ||
amplitudeApiKey={amplitudeApiKey} | ||
googleAnalyticsId={googleAnalyticsId} | ||
providers={providers} | ||
> | ||
<AppBody {...props} /> | ||
</AppShellRoot> | ||
Comment on lines
+69
to
+76
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Split the AppShell into 2 components so we can have the fumadocs provider after |
||
); | ||
|
||
type AppBodyProps = Pick< | ||
ComponentProps<typeof Header>, | ||
"appName" | "mainCta" | "extraCta" | "displaySupportButton" | ||
|
Uh oh!
There was an error while loading. Please reload this page.