-
Notifications
You must be signed in to change notification settings - Fork 297
feat(component-library): table grid #3088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 11 commits
dff6fed
b5574f6
e78820a
4b43d05
cb93200
8b1cd3b
dc0c5b5
7f9292a
0548bde
568b34e
c125e88
42ca144
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
export const dummyRowData = [ | ||
{ id: 1, feed: "BTC/USD", price: 54_392.28, confidence: 4.31 }, | ||
{ id: 2, feed: "ETH/USD", price: 3129.5, confidence: 7.92 }, | ||
{ id: 3, feed: "SOL/USD", price: 142.11, confidence: 2.48 }, | ||
{ id: 4, feed: "DOGE/USD", price: 0.21, confidence: 8.17 }, | ||
{ id: 5, feed: "BNB/USD", price: 587.44, confidence: 3.22 }, | ||
{ id: 6, feed: "XRP/USD", price: 0.76, confidence: 6.43 }, | ||
{ id: 7, feed: "ADA/USD", price: 1.42, confidence: 9.88 }, | ||
{ id: 8, feed: "DOT/USD", price: 32.67, confidence: 1.76 }, | ||
{ id: 9, feed: "MATIC/USD", price: 2.04, confidence: 12.11 }, | ||
{ id: 10, feed: "ATOM/USD", price: 14.55, confidence: 4.98 }, | ||
|
||
{ id: 11, feed: "LTC/USD", price: 228.77, confidence: 5.66 }, | ||
{ id: 12, feed: "TRX/USD", price: 0.12, confidence: 6.44 }, | ||
{ id: 13, feed: "NEAR/USD", price: 9.83, confidence: 7.15 }, | ||
{ id: 14, feed: "APT/USD", price: 11.25, confidence: 3.9 }, | ||
{ id: 15, feed: "SUI/USD", price: 1.77, confidence: 9.28 }, | ||
{ id: 16, feed: "ARB/USD", price: 1.54, confidence: 11.32 }, | ||
{ id: 17, feed: "OP/USD", price: 2.12, confidence: 10.44 }, | ||
{ id: 18, feed: "FIL/USD", price: 36.8, confidence: 2.27 }, | ||
{ id: 19, feed: "ICP/USD", price: 18.93, confidence: 6.15 }, | ||
{ id: 20, feed: "BTC/USD", price: 61_034.72, confidence: 4.08 }, | ||
|
||
{ id: 21, feed: "ETH/USD", price: 2940.18, confidence: 7.54 }, | ||
{ id: 22, feed: "SOL/USD", price: 153.22, confidence: 2.17 }, | ||
{ id: 23, feed: "DOGE/USD", price: 0.25, confidence: 11.28 }, | ||
{ id: 24, feed: "BNB/USD", price: 612.93, confidence: 3.1 }, | ||
{ id: 25, feed: "XRP/USD", price: 0.79, confidence: 5.94 }, | ||
{ id: 26, feed: "ADA/USD", price: 1.52, confidence: 9.45 }, | ||
{ id: 27, feed: "DOT/USD", price: 28.65, confidence: 1.93 }, | ||
{ id: 28, feed: "MATIC/USD", price: 2.14, confidence: 11.57 }, | ||
{ id: 29, feed: "ATOM/USD", price: 13.72, confidence: 5.36 }, | ||
{ id: 30, feed: "LTC/USD", price: 239.85, confidence: 4.79 }, | ||
|
||
{ id: 31, feed: "TRX/USD", price: 0.11, confidence: 6.72 }, | ||
{ id: 32, feed: "NEAR/USD", price: 10.44, confidence: 7.09 }, | ||
{ id: 33, feed: "APT/USD", price: 10.85, confidence: 4.02 }, | ||
{ id: 34, feed: "SUI/USD", price: 1.83, confidence: 9.91 }, | ||
{ id: 35, feed: "ARB/USD", price: 1.61, confidence: 10.75 }, | ||
{ id: 36, feed: "OP/USD", price: 2.25, confidence: 8.66 }, | ||
{ id: 37, feed: "FIL/USD", price: 34.72, confidence: 3.48 }, | ||
{ id: 38, feed: "ICP/USD", price: 19.14, confidence: 5.28 }, | ||
{ id: 39, feed: "BTC/USD", price: 57_902.41, confidence: 3.76 }, | ||
{ id: 40, feed: "ETH/USD", price: 3055.91, confidence: 7.11 }, | ||
|
||
{ id: 41, feed: "SOL/USD", price: 161.83, confidence: 1.99 }, | ||
{ id: 42, feed: "DOGE/USD", price: 0.19, confidence: 8.74 }, | ||
{ id: 43, feed: "BNB/USD", price: 595.27, confidence: 3.85 }, | ||
{ id: 44, feed: "XRP/USD", price: 0.73, confidence: 6.2 }, | ||
{ id: 45, feed: "ADA/USD", price: 1.48, confidence: 10.51 }, | ||
{ id: 46, feed: "DOT/USD", price: 30.12, confidence: 2.09 }, | ||
{ id: 47, feed: "MATIC/USD", price: 2.19, confidence: 12.88 }, | ||
{ id: 48, feed: "ATOM/USD", price: 14.04, confidence: 4.62 }, | ||
{ id: 49, feed: "LTC/USD", price: 244.31, confidence: 5.12 }, | ||
{ id: 50, feed: "TRX/USD", price: 0.13, confidence: 6.91 }, | ||
|
||
{ id: 51, feed: "NEAR/USD", price: 9.95, confidence: 6.84 }, | ||
{ id: 52, feed: "APT/USD", price: 11.42, confidence: 4.44 }, | ||
{ id: 53, feed: "SUI/USD", price: 1.79, confidence: 8.93 }, | ||
{ id: 54, feed: "ARB/USD", price: 1.59, confidence: 10.13 }, | ||
{ id: 55, feed: "OP/USD", price: 2.31, confidence: 9.2 }, | ||
{ id: 56, feed: "FIL/USD", price: 37.02, confidence: 2.72 }, | ||
{ id: 57, feed: "ICP/USD", price: 18.67, confidence: 6.01 }, | ||
{ id: 58, feed: "BTC/USD", price: 59_243.82, confidence: 3.92 }, | ||
{ id: 59, feed: "ETH/USD", price: 3089.27, confidence: 7.47 }, | ||
{ id: 60, feed: "SOL/USD", price: 158.71, confidence: 2.26 }, | ||
|
||
{ id: 61, feed: "DOGE/USD", price: 0.22, confidence: 8.55 }, | ||
{ id: 62, feed: "BNB/USD", price: 601.35, confidence: 3.69 }, | ||
{ id: 63, feed: "XRP/USD", price: 0.75, confidence: 5.72 }, | ||
{ id: 64, feed: "ADA/USD", price: 1.55, confidence: 9.68 }, | ||
{ id: 65, feed: "DOT/USD", price: 31.44, confidence: 1.88 }, | ||
{ id: 66, feed: "MATIC/USD", price: 2.23, confidence: 11.83 }, | ||
{ id: 67, feed: "ATOM/USD", price: 14.88, confidence: 4.34 }, | ||
{ id: 68, feed: "LTC/USD", price: 237.72, confidence: 5.55 }, | ||
{ id: 69, feed: "TRX/USD", price: 0.14, confidence: 6.63 }, | ||
{ id: 70, feed: "NEAR/USD", price: 10.17, confidence: 7.03 }, | ||
|
||
{ id: 71, feed: "APT/USD", price: 11.07, confidence: 3.71 }, | ||
{ id: 72, feed: "SUI/USD", price: 1.81, confidence: 9.44 }, | ||
{ id: 73, feed: "ARB/USD", price: 1.63, confidence: 11.09 }, | ||
{ id: 74, feed: "OP/USD", price: 2.19, confidence: 10.27 }, | ||
{ id: 75, feed: "FIL/USD", price: 35.91, confidence: 3.18 }, | ||
{ id: 76, feed: "ICP/USD", price: 19.35, confidence: 5.64 }, | ||
{ id: 77, feed: "BTC/USD", price: 60_517.49, confidence: 4.02 }, | ||
{ id: 78, feed: "ETH/USD", price: 3112.84, confidence: 7.21 }, | ||
{ id: 79, feed: "SOL/USD", price: 149.26, confidence: 2.51 }, | ||
{ id: 80, feed: "DOGE/USD", price: 0.2, confidence: 9.12 }, | ||
]; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
@use "../theme"; | ||
|
||
.tableGrid { | ||
--ag-browser-color-scheme: light-dark(light, dark); | ||
--ag-background-color: #{theme.color("background", "primary")}; | ||
--ag-header-background-color: var(--ag-background-color); | ||
--ag-foreground-color: #{theme.color("paragraph")}; | ||
--ag-accent-color: #{theme.color("button", "outline", "background", "active")}; | ||
--ag-header-font-size: #{theme.font-size("xs")}; | ||
--ag-header-font-weight: #{theme.font-weight("medium")}; | ||
--ag-cell-font-size: #{theme.font-size("xs")}; | ||
--ag-wrapper-border: none; | ||
--ag-cell-text-color: #{theme.color("paragraph")}; | ||
--ag-data-font-size: #{theme.font-size("base")}; | ||
|
||
height: 100%; | ||
} | ||
|
||
.defaultCellContainer { | ||
height: 100%; | ||
display: flex; | ||
align-items: center; | ||
} | ||
|
||
.skeletonContainer { | ||
height: theme.spacing(10); | ||
width: 100%; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,129 @@ | ||
import { ChartLine } from "@phosphor-icons/react/dist/ssr/ChartLine"; | ||
import type { Meta, StoryObj } from "@storybook/react"; | ||
import BtcIcon from "cryptocurrency-icons/svg/color/btc.svg"; | ||
|
||
import { Badge } from "../Badge"; | ||
import { SymbolPairTag } from "../SymbolPairTag"; | ||
import { dummyRowData } from "./dummy-row-data"; | ||
import { TableGrid as TableGridComponent } from "./index.jsx"; | ||
|
||
const meta = { | ||
component: TableGridComponent, | ||
parameters: { | ||
layout: "padded", | ||
}, | ||
argTypes: { | ||
colDefs: { | ||
table: { | ||
disable: true, | ||
}, | ||
}, | ||
rowData: { | ||
table: { | ||
disable: true, | ||
}, | ||
}, | ||
className: { | ||
table: { | ||
disable: true, | ||
}, | ||
}, | ||
cardProps: { | ||
table: { | ||
category: "Outer Card", | ||
}, | ||
}, | ||
isLoading: { | ||
control: "boolean", | ||
table: { | ||
category: "State", | ||
}, | ||
}, | ||
}, | ||
} satisfies Meta<typeof TableGridComponent>; | ||
export default meta; | ||
|
||
const PriceCellRenderer = ({ value }: { value: number }) => ( | ||
<span style={{ height: "100%", display: "flex", alignItems: "center" }}> | ||
{`$${value.toLocaleString(undefined, { | ||
minimumFractionDigits: 2, | ||
maximumFractionDigits: 2, | ||
})}`} | ||
</span> | ||
); | ||
|
||
const ConfidenceCellRenderer = ({ value }: { value: number }) => ( | ||
<span | ||
style={{ height: "100%", display: "flex", alignItems: "center" }} | ||
>{`+/- ${value.toFixed(2)}%`}</span> | ||
); | ||
|
||
const FeedCellRenderer = ({ value }: { value: string }) => ( | ||
<div style={{ height: "100%", display: "flex", alignItems: "center" }}> | ||
<SymbolPairTag | ||
displaySymbol={value} | ||
icon={<BtcIcon />} | ||
description={value} | ||
/> | ||
</div> | ||
); | ||
|
||
const FeedCellRendererLoading = () => ( | ||
<div style={{ height: "100%", display: "flex", alignItems: "center" }}> | ||
<SymbolPairTag isLoading /> | ||
</div> | ||
); | ||
Comment on lines
+46
to
+75
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Very interesting discussion to be had here as well regarding what the right abstractions are.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah I think with these kind of things the best way is let things as simple as possible and then create the abstraction as needed, when we start duplicating the code or having a similar logic in 2-3 places. |
||
|
||
const args = { | ||
colDefs: [ | ||
{ | ||
headerName: "ID", | ||
field: "id", | ||
}, | ||
{ | ||
headerName: "PRICE FEED", | ||
field: "feed", | ||
cellRenderer: FeedCellRenderer, | ||
loadingCellRenderer: FeedCellRendererLoading, | ||
flex: 2, | ||
}, | ||
{ | ||
headerName: "PRICE", | ||
field: "price", | ||
flex: 3, | ||
cellRenderer: PriceCellRenderer, | ||
}, | ||
{ | ||
headerName: "CONFIDENCE", | ||
field: "confidence", | ||
cellRenderer: ConfidenceCellRenderer, | ||
}, | ||
], | ||
rowHeight: 70, | ||
rowData: dummyRowData, | ||
}; | ||
|
||
export const TableGrid = { | ||
args, | ||
} satisfies StoryObj<typeof TableGridComponent>; | ||
|
||
export const PriceFeedsCard = { | ||
render: (props) => { | ||
return <TableGridComponent {...props} />; | ||
}, | ||
args: { | ||
...args, | ||
pagination: true, | ||
cardProps: { | ||
icon: <ChartLine />, | ||
title: ( | ||
<> | ||
<span>Price Feeds</span> | ||
<Badge style="filled" variant="neutral" size="md"> | ||
{args.rowData.length} | ||
</Badge> | ||
</> | ||
), | ||
}, | ||
}, | ||
} satisfies StoryObj<typeof TableGridComponent>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!