Skip to content

fix(pyth-lazer-agent): Support jrpc string ids #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 11, 2025
Merged

fix(pyth-lazer-agent): Support jrpc string ids #3125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e14d642
fix(pyth-lazer-agent): Support jrpc string ids
merolish Oct 10, 2025
299481e
bump version
merolish Oct 10, 2025
e6768c8
Merge branch 'main' of github.com:pyth-network/pyth-crosschain into m…
merolish Oct 10, 2025
e90d1dd
Bump agent version
merolish Oct 10, 2025
b6cce6c
bump agent version
merolish Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions apps/pyth-lazer-agent/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
[package]
name = "pyth-lazer-agent"
version = "0.5.2"
version = "0.6.0"
edition = "2024"
description = "Pyth Lazer Agent"
license = "Apache-2.0"
repository = "https://github.com/pyth-network/pyth-crosschain"

[dependencies]
pyth-lazer-publisher-sdk = "0.12.1"
pyth-lazer-protocol = "0.15.1"
pyth-lazer-publisher-sdk = "0.16.1"
pyth-lazer-protocol = "0.18.1"

anyhow = "1.0.98"
backoff = "0.4.0"
Expand Down
45 changes: 25 additions & 20 deletions apps/pyth-lazer-agent/src/jrpc_handle.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ use futures::{AsyncRead, AsyncWrite};
use futures_util::io::{BufReader, BufWriter};
use hyper_util::rt::TokioIo;
use pyth_lazer_protocol::jrpc::{
FeedUpdateParams, GetMetadataParams, JrpcCall, JrpcError, JrpcErrorResponse, JrpcResponse,
JrpcSuccessResponse, JsonRpcVersion, PythLazerAgentJrpcV1, SymbolMetadata,
FeedUpdateParams, GetMetadataParams, JrpcCall, JrpcError, JrpcErrorResponse, JrpcId,
JrpcResponse, JrpcSuccessResponse, JsonRpcVersion, PythLazerAgentJrpcV1, SymbolMetadata,
};
use soketto::Sender;
use soketto::handshake::http::Server;
Expand Down Expand Up @@ -83,7 +83,7 @@ async fn try_handle_jrpc(
JrpcErrorResponse {
jsonrpc: JsonRpcVersion::V2,
error: JrpcError::InternalError(err.to_string()).into(),
id: None,
id: JrpcId::Null,
},
))?
.as_str(),
Expand All @@ -103,18 +103,23 @@ async fn handle_jrpc_inner<T: AsyncRead + AsyncWrite + Unpin>(
match serde_json::from_slice::<PythLazerAgentJrpcV1>(receive_buf.as_slice()) {
Ok(jrpc_request) => match jrpc_request.params {
JrpcCall::PushUpdate(request_params) => {
handle_push_update(sender, lazer_publisher, request_params, jrpc_request.id).await
handle_push_update(
sender,
lazer_publisher,
request_params,
jrpc_request.id.clone(),
)
.await
}
JrpcCall::PushUpdates(request_params) => {
for feed in request_params {
handle_push_update(sender, lazer_publisher, feed, jrpc_request.id).await?;
handle_push_update(sender, lazer_publisher, feed, jrpc_request.id.clone())
.await?;
}
Ok(())
}
JrpcCall::GetMetadata(request_params) => {
if let Some(request_id) = jrpc_request.id {
handle_get_metadata(sender, config, request_params, request_id).await
} else {
JrpcCall::GetMetadata(request_params) => match jrpc_request.id {
JrpcId::Null => {
send_json(
sender,
&JrpcErrorResponse {
Expand All @@ -123,12 +128,13 @@ async fn handle_jrpc_inner<T: AsyncRead + AsyncWrite + Unpin>(
"The request to method 'get_metadata' requires an 'id'".to_string(),
)
.into(),
id: None,
id: JrpcId::Null,
},
)
.await
}
}
_ => handle_get_metadata(sender, config, request_params, jrpc_request.id).await,
},
},
Err(err) => {
debug!("Error parsing JRPC request: {}", err);
Expand All @@ -137,7 +143,7 @@ async fn handle_jrpc_inner<T: AsyncRead + AsyncWrite + Unpin>(
&JrpcErrorResponse {
jsonrpc: JsonRpcVersion::V2,
error: JrpcError::ParseError(err.to_string()).into(),
id: None,
id: JrpcId::Null,
},
)
.await
Expand Down Expand Up @@ -199,14 +205,15 @@ async fn handle_push_update<T: AsyncRead + AsyncWrite + Unpin>(
sender: &mut Sender<T>,
lazer_publisher: &LazerPublisher,
request_params: FeedUpdateParams,
request_id: Option<i64>,
request_id: JrpcId,
) -> anyhow::Result<()> {
match lazer_publisher
.push_feed_update(request_params.clone().into())
.await
{
Ok(_) => {
if let Some(request_id) = request_id {
Ok(_) => match request_id {
JrpcId::Null => Ok(()),
_ => {
send_json(
sender,
&JrpcSuccessResponse::<String> {
Expand All @@ -216,10 +223,8 @@ async fn handle_push_update<T: AsyncRead + AsyncWrite + Unpin>(
},
)
.await
} else {
Ok(())
}
}
},
Err(err) => {
debug!("error while sending updates: {:?}", err);
send_json(
Expand All @@ -239,7 +244,7 @@ async fn handle_get_metadata<T: AsyncRead + AsyncWrite + Unpin>(
sender: &mut Sender<T>,
config: &Config,
request_params: GetMetadataParams,
request_id: i64,
request_id: JrpcId,
) -> anyhow::Result<()> {
match get_metadata(config.clone()).await {
Ok(symbols) => {
Expand All @@ -262,7 +267,7 @@ async fn handle_get_metadata<T: AsyncRead + AsyncWrite + Unpin>(
&JrpcErrorResponse {
jsonrpc: JsonRpcVersion::V2,
error: JrpcError::InternalError(err.to_string()).into(),
id: Some(request_id),
id: request_id,
},
)
.await
Expand Down