Conversation
… LTS versions available on Vercel. also fixed linting issues that snuck into main
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
…uild, and also fixed functions being passed between mixed server and client components (you cannot do this)
…atasources array failing referential equality checks
… has a built-in watcher
| } | ||
| } No newline at end of file | ||
| }, | ||
| "browserslist": [ |
There was a problem hiding this comment.
general good practice to have to be explicit about which browsers we support. this snippet was added to all next.js app package.json files
| "type": "module", | ||
| "engines": { | ||
| "node": ">=22.14.0" | ||
| "node": "^24.0.0" |
There was a problem hiding this comment.
upgraded all engines to be at least node 24
| symbol: selectedSource, | ||
| }); | ||
|
|
||
| const replayDataSources = useMemo( |
There was a problem hiding this comment.
fixes an infinite render bug that, strangely, only occurred in Next v16 and wasn't happening in v15. This locks down the array reference so it no longer changes every render
| "cache": false | ||
| }, | ||
| "start:dev": { | ||
| "with": ["@pythnetwork/component-library#start:dev"] |
There was a problem hiding this comment.
for local dev convenience, rebuilds the component library when changes to it are made and we're doing local dev in Insights Hub
| import { Storable } from "./base"; | ||
| import type { TokenId } from "./token"; | ||
| import { execFileAsync, hasProperty } from "../utils/utils"; | ||
| import { execFileAsync } from "../utils/exec-file-async"; |
There was a problem hiding this comment.
needed to move this util to its own file, as previously, it was combined with other utils that were being imported on the client, which Next v15 handled with silent failures, but Next v16 dies on because it is much stricter about accidental node-specific imports leaking in to UI code.
governance/xc_admin/packages/xc_admin_frontend/components/tabs/Proposals/Proposal.tsx
Show resolved
Hide resolved
| name="viewport" | ||
| content="width=device-width, initial-scale=1.0, maximum-scale=1.0" | ||
| /> | ||
| {generateDefaultSeo(SEO)} |
There was a problem hiding this comment.
latest next-seo package hand API changes, so this keeps the behavior the same as before, but uses the new API
| turbopack: { | ||
| resolveAlias: { | ||
| fs: { | ||
| /** |
There was a problem hiding this comment.
comment should hopefully be self explanatory 🙂
| "start:prod": "next start --port 3004", | ||
| "fix:format": "prettier --write .", | ||
| "fix:lint": "next lint --fix --max-warnings 0", | ||
| "fix:lint": "eslint --fix .", |
There was a problem hiding this comment.
this is the cause for the extra noise for the xc_admin_frontend app. previously, it was using its own, local-only eslint ruleset
| "extends": "@cprussin/tsconfig/nextjs.json", | ||
| "include": [ | ||
| "*.d.ts", | ||
| "**/*.d.ts", |
There was a problem hiding this comment.
moved the .d.ts files that were local to this project to be in the src folder, which allows us to leverage ts-duality's built-in --copyOtherFiles. Without this change, mixed roots were detected, so copying files would result in a wonky dist/ folder structure
| @@ -1,4 +1,4 @@ | |||
| nodejs 22.14.0 | |||
| pnpm 10.7.0 | |||
| nodejs 24.12.0 | |||
There was a problem hiding this comment.
updates the asdf and mise config (@cprussin you might need to update the .nix config, as well)
| "tasks": { | ||
| "//#fix": { | ||
| "dependsOn": ["//#fix:lint", "//#fix:format"], | ||
| "dependsOn": [ |
There was a problem hiding this comment.
linting / formatting. sorry for the noise
governance/xc_admin/packages/xc_admin_frontend/hooks/useMultisig.ts
Outdated
Show resolved
Hide resolved
governance/xc_admin/packages/xc_admin_frontend/hooks/usePyth.ts
Outdated
Show resolved
Hide resolved
governance/xc_admin/packages/xc_admin_frontend/turbopack-hacks/empty.ts
Outdated
Show resolved
Hide resolved
…ogging the error via console.error

also fixed linting issues that snuck into main
Summary
As the title mentions, this upgrades all
nodeandpnpmdeps to use the absolute latest LTS versions. This repo has been falling a bit behind. Additionally, with the Node 24 upgrade, and a small node loader, we should be able to run TypeScript natively like Bun, without a compilation step (and without the monkey patching of libraries, like the one for@ton/blueprintthat we've needed to do to work with tsx)Rationale
See comment, above, for the rationale.
How has this been tested?