-
Notifications
You must be signed in to change notification settings - Fork 2
chore Add some more test #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,29 @@ contract MorphoPythOracleTest is Test { | |
function setUp() public { | ||
mockPyth = new MockPyth(60, 1); | ||
|
||
// Update the price feed | ||
mockPyth.updatePriceFeeds{value: 2}(getPriceUpdateData()); | ||
|
||
assertEq(mockPyth.getPriceUnsafe(pythWbtcUsdFeed).price, 30000 * 1e8); | ||
assertEq(mockPyth.getPriceUnsafe(pythUsdtUsdFeed).price, 1 * 1e8); | ||
|
||
oracle = new MorphoPythOracle( | ||
address(mockPyth), | ||
vaultZero, | ||
1, | ||
pythWbtcUsdFeed, | ||
pythFeedZero, | ||
pythWbtcUsdTokenDecimals, | ||
vaultZero, | ||
1, | ||
pythUsdtUsdFeed, | ||
pythFeedZero, | ||
pythUsdtUsdTokenDecimals, | ||
oneMinute | ||
); | ||
} | ||
|
||
function getPriceUpdateData() internal view returns (bytes[] memory) { | ||
// Create price feed update data for WBTC/USD | ||
bytes[] memory updateData = new bytes[](2); | ||
updateData[0] = mockPyth.createPriceFeedUpdateData( | ||
|
@@ -36,25 +59,7 @@ contract MorphoPythOracleTest is Test { | |
uint64(block.timestamp), | ||
uint64(block.timestamp) | ||
); | ||
// Update the price feed | ||
mockPyth.updatePriceFeeds{value: 2}(updateData); | ||
assertEq(mockPyth.getPriceUnsafe(pythWbtcUsdFeed).price, 30000 * 1e8); | ||
assertEq(mockPyth.getPriceUnsafe(pythUsdtUsdFeed).price, 1 * 1e8); | ||
|
||
oracle = new MorphoPythOracle( | ||
address(mockPyth), | ||
vaultZero, | ||
1, | ||
pythWbtcUsdFeed, | ||
pythFeedZero, | ||
pythWbtcUsdTokenDecimals, | ||
vaultZero, | ||
1, | ||
pythUsdtUsdFeed, | ||
pythFeedZero, | ||
pythUsdtUsdTokenDecimals, | ||
oneHour | ||
); | ||
return updateData; | ||
} | ||
|
||
function testInitialSetup() public { | ||
|
@@ -88,4 +93,48 @@ contract MorphoPythOracleTest is Test { | |
) / uint256(int256(mockPyth.getPriceUnsafe(pythUsdtUsdFeed).price)) | ||
); | ||
} | ||
|
||
function testPriceFeedAgeValidation() public { | ||
// This should work - price is current | ||
uint256 price = oracle.price(); | ||
assertTrue(price > 0); | ||
} | ||
|
||
function testPriceFeedStalePrice() public { | ||
vm.warp(block.timestamp + oneMinute + 1); | ||
// This should revert due to stale price | ||
vm.expectRevert(bytes4(0x19abf40e)); // StalePrice error | ||
oracle.price(); | ||
} | ||
|
||
function testZeroPriceHandling() public { | ||
// Set up price feeds with zero price | ||
bytes[] memory updateData = new bytes[](2); | ||
updateData[0] = mockPyth.createPriceFeedUpdateData( | ||
pythWbtcUsdFeed, | ||
0, // Zero price | ||
1000000, // Confidence interval | ||
-6, // Expo (-6 means price is multiplied by 10^-6) | ||
0, // EMA price | ||
0, // EMA Confidence interval | ||
uint64(block.timestamp) + 1, | ||
uint64(block.timestamp) + 1 | ||
); | ||
|
||
updateData[1] = mockPyth.createPriceFeedUpdateData( | ||
pythUsdtUsdFeed, | ||
1 * 1e8, // Price of 1 USD | ||
0, // Confidence interval | ||
-6, // Expo (-6 means price is multiplied by 10^-6) | ||
1 * 1e8, // EMA price | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto |
||
0, // EMA Confidence interval | ||
uint64(block.timestamp) + 1, | ||
uint64(block.timestamp) + 1 | ||
); | ||
mockPyth.updatePriceFeeds{value: 2}(updateData); | ||
|
||
// Zero price should be valid (price = 0 is allowed, only negative is rejected) | ||
uint256 price = oracle.price(); | ||
assertEq(price, 0); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpik: it should be 1e6