Skip to content

Handle blank or malformed PO-Revision-Date in .po file headers #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle blank or malformed PO-Revision-Date in .po file headers #1222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions babel/messages/catalog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,18 @@ def _has_python_brace_format(string: str) -> bool:


def _parse_datetime_header(value: str) -> datetime.datetime:
match = re.match(r'^(?P<datetime>.*?)(?P<tzoffset>[+-]\d{4})?$', value)
# Handle blank or missing values
if not value or not value.strip():
return None

dt = datetime.datetime.strptime(match.group('datetime'), '%Y-%m-%d %H:%M')
match = re.match(r'^(?P<datetime>.*?)(?P<tzoffset>[+-]\d{4})?$', value.strip())
if not match or not match.group('datetime').strip():
return None

try:
dt = datetime.datetime.strptime(match.group('datetime').strip(), '%Y-%m-%d %H:%M')
except ValueError:
return None

# Separate the offset into a sign component, hours, and # minutes
tzoffset = match.group('tzoffset')
Expand Down