Skip to content

Manually apply ruff/flake8-implicit-str-concat rule ISC002 #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DimitriPapadopoulos wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Manually apply ruff/flake8-implicit-str-concat rule ISC002 #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions testing/cffi0/test_ownlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,8 @@ def setup_class(cls):
if sys.maxsize > 2**32:
arch = 'amd64'
if os.path.isfile(vcvarsall):
cmd = '"%s" %s' % (vcvarsall, arch) + ' & cl.exe testownlib.c ' \
' /LD /Fetestownlib.dll'
cmd = '"%s" %s & cl.exe testownlib.c /LD /Fetestownlib.dll' % (
vcvarsall, arch)
Copy link
Contributor

@mattip mattip Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe nicer as an f-string, after #214 and #124

Copy link
Contributor Author

@DimitriPapadopoulos DimitriPapadopoulos Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, but I wanted to apply this #214. I'll rebase after the first PR is applied, whichever it is.

subprocess.check_call(cmd, cwd = str(udir), shell=True)
os.rename(f"{udir}\\testownlib.dll", dll_path)
cls.module = dll_path
Expand Down