Upgrade tests to support Python 3.13 #1335
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
📋 Review Summary
This pull request successfully updates the CI/CD workflows to include Python 3.13 for testing and quality checks. The addition of ruff as a development dependency and an invoke task is a great improvement for code quality.
🔍 General Feedback
- The changes to the GitHub Actions workflows are correct and align with the goal of supporting Python 3.13.
- The documentation cleanup in
scripting.rstis a nice touch. - There is a concern regarding the dependency versioning in the
Pipfile, which is detailed in the inline comment.
Comment on lines
+8
to
10
| setuptools = "*" | ||
| wcwidth = "*" | ||
|
|
There was a problem hiding this comment.
🟠 Changing the version specifiers for pyperclip, setuptools, and wcwidth to "*" is not recommended. Using "*" can introduce breaking changes from future releases of these packages, leading to unexpected failures. It's better to specify a compatible version range, for example, ">=1.6", to ensure build stability.
Suggested change
| setuptools = "*" | |
| wcwidth = "*" | |
| pyperclip = ">=1.6" | |
| setuptools = ">=34.4" | |
| wcwidth = ">=0.1.7" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade tests to support Python 3.13 and use it as the default for linting/formatting/mypy