Change CommandSet._cmd to a read-only property which never returns None. #1371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anselor
reviewed
Nov 5, 2024
This addresses issue where CommandSet methods which only run after it is registered have to either check if self._cmd is None or cast it to the CLI class to avoid type checker errors.
kmvanbrunt
force-pushed
the
_cmd_property
branch
from
b2c1908 to
87a3e5d
Compare
tleonhardt
previously approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue where
CommandSetmethods which only run after it is registered have to either check ifself._cmdisNoneor cast it to the CLI class to avoid type checker errors.