Skip to content

Conversation

kmvanbrunt
Copy link
Member

No description provided.

Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.77%. Comparing base (4f3ee8d) to head (7034777).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1471      +/-   ##
==========================================
+ Coverage   98.41%   98.77%   +0.35%     
==========================================
  Files          21       21              
  Lines        5868     5878      +10     
==========================================
+ Hits         5775     5806      +31     
+ Misses         93       72      -21     
Flag Coverage Δ
unittests 98.77% <100.00%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tleonhardt tleonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Mainly need to update CHANGELOG and documentation. But various comments, at least some of which should likely be addressed.

theagilehacker
theagilehacker previously approved these changes Aug 2, 2025
Copy link
Contributor

@theagilehacker theagilehacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I learned a couple of new Python tricks reviewing this change.
I am still not quite versed in the code base enough to grok it enough to make any design/code suggestions, other than logic issues, of which there are non that I could see.

tleonhardt
tleonhardt previously approved these changes Aug 5, 2025
@kmvanbrunt kmvanbrunt force-pushed the enable_rich_printing branch from 05c8b66 to 7034777 Compare August 5, 2025 14:00
Copy link
Member

@tleonhardt tleonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you parameterized the chop argument in the one unit test.

LGTM

@kmvanbrunt kmvanbrunt merged commit 5ac81d4 into main Aug 5, 2025
34 checks passed
@kmvanbrunt kmvanbrunt deleted the enable_rich_printing branch August 5, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants