-
Notifications
You must be signed in to change notification settings - Fork 124
Enabled all printing methods to support Rich objects. #1471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1471 +/- ##
==========================================
+ Coverage 98.41% 98.77% +0.35%
==========================================
Files 21 21
Lines 5868 5878 +10
==========================================
+ Hits 5775 5806 +31
+ Misses 93 72 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Mainly need to update CHANGELOG
and documentation. But various comments, at least some of which should likely be addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I learned a couple of new Python tricks reviewing this change.
I am still not quite versed in the code base enough to grok it enough to make any design/code suggestions, other than logic issues, of which there are non that I could see.
67fc886
to
ee44321
Compare
ee44321
to
05c8b66
Compare
05c8b66
to
7034777
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how you parameterized the chop
argument in the one unit test.
LGTM
No description provided.