-
Notifications
You must be signed in to change notification settings - Fork 124
Refactored cmd2 to better account for our use of Rich. #1477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Added string_utils.py which contains all string utility functions. This includes quoting and alignment functions from utils.py. This also includes style-related functions from ansi.py. * Added colors.py which contains all color names supported by Rich. * Added styles.py which contains the names of all cmd2-specific styles. * Moved string styling functionality from ansi.py to string_utils.py. * Removed all text style Enums from ansi.py since we use Rich. * Renamed ansi.py to terminal_utils.py to reflect the functions left in it. * Removed table_creation.py since we use Rich tables now.
…longer contains a StrEnum
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1477 +/- ##
=======================================
Coverage ? 98.50%
=======================================
Files ? 23
Lines ? 4884
Branches ? 0
=======================================
Hits ? 4811
Misses ? 73
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks really good. Just requesting some minor changes for ease of maintainability.
b414ec5
to
df0eb4a
Compare
df0eb4a
to
24676aa
Compare
033ca31
to
dd76861
Compare
dd76861
to
4621211
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In the future we'll need to spend some more time updating the documentation for all of these changes. But this looks good for now.
…tent with our other global settings.
Refactored cmd2 to better account for our use of Rich.