Skip to content

Conversation

kmvanbrunt
Copy link
Member

No description provided.

Copy link
Contributor

🤖 Hi @kmvanbrunt, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.81%. Comparing base (fd72525) to head (5e4a6a2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1514   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files          23       23           
  Lines        4961     4961           
=======================================
  Hits         4902     4902           
  Misses         59       59           
Flag Coverage Δ
unittests 98.81% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This pull request fixes a bug where a trailing newline could be stripped when applying styles. The fix is correct and the accompanying tests are well-written and cover the edge cases.

🔍 General Feedback

  • The change from == "\n" to .endswith("\n") is a good improvement to handle more cases.
  • The new test test_apply_style_wrapper_word_wrap is a great addition to ensure that word wrapping is not affected by the patch.
  • The overall quality of the code and tests is high.

@tleonhardt tleonhardt merged commit e3e0d6f into main Sep 16, 2025
42 checks passed
@tleonhardt tleonhardt deleted the patch_fix branch September 16, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants