Skip to content

Conversation

tleonhardt
Copy link
Member

@tleonhardt tleonhardt commented Sep 17, 2025

The auto_load_commands argument to the cmd2.Cmd.__init__ initializer now defaults to False.

Also:

  • The tests_isolated directory has been deleted and all tests underneath there have been moved under tests

Switching the default value for auto_load_commands was required in order to be able to run all of the tests in the same suite. Alternatively, we would have had to change every single cmd2.Cmd instance in the main tests and set auto_load_commands=False.

Also:
- The `tests_isolated` directory has been deleted and all tests underneath there have been moved under `tests`
Copy link
Contributor

🤖 Hi @tleonhardt, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.92%. Comparing base (26ca1f9) to head (afed344).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1520      +/-   ##
==========================================
+ Coverage   98.90%   98.92%   +0.02%     
==========================================
  Files          21       21              
  Lines        4933     4933              
==========================================
+ Hits         4879     4880       +1     
+ Misses         54       53       -1     
Flag Coverage Δ
unittests 98.92% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tleonhardt tleonhardt self-assigned this Sep 17, 2025
@tleonhardt tleonhardt added this to the 3.0.0 milestone Sep 17, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This pull request updates the default behavior of auto_load_commands to False, which is a significant but well-documented change. The consolidation of tests from tests_isolated into the tests directory is a great improvement for maintainability.

🔍 General Feedback

  • The changes are well-documented in the CHANGELOG.md and docs/upgrades.md files.
  • The tests have been updated to reflect the new default behavior of auto_load_commands.
  • The removal of the tests_isolated directory simplifies the project structure.

@tleonhardt tleonhardt merged commit 21657a6 into main Sep 17, 2025
36 checks passed
@tleonhardt tleonhardt deleted the no-more-isolated-tests branch September 17, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants