Skip to content

fix: check for unknown/None content_type for pastebin uploader #3413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: check for unknown/None content_type for pastebin uploader #3413

wants to merge 3 commits into from

Conversation

@onerandomusername
Copy link
Contributor

closes #3402

wookie184
wookie184 requested changes Oct 21, 2025
View reviewed changes
bot/exts/utils/attachment_pastebin_uploader.py Outdated
for attachment in message.attachments:
if (
attachment.content_type
and attachment.content_type.startswith("text/plain")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also want to offer to upload files like text/csv or application/json, I think having a charset is enough to offer to upload it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, should I check that the charset actually equals utf-8?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, didn't notice that was already checked in https://github.com/onerandomusername/pydis-bot/blob/main/bot/exts/utils/attachment_pastebin_uploader.py#L40-L41

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

46e87ea (#3413)

wookie184
wookie184 approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@onerandomusername onerandomusername marked this pull request as draft October 24, 2025 22:47
@onerandomusername
Copy link
Contributor Author

Converted to draft for now as I forgot to add checking for the other use mentioned in the attached issue:

bot/bot/exts/filtering/filtering.py

Line 238 in f0e4d45

for a in msg.attachments if "charset" in a.content_type

@onerandomusername onerandomusername marked this pull request as ready for review October 26, 2025 04:32
@onerandomusername
Copy link
Contributor Author

fixed the attribute error in filtering and marked as ready for review again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wookie184 wookie184 wookie184 approved these changes

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Issues due to lack of check for when Attachment.content_type is None

3 participants

@onerandomusername @wookie184 @jb3