-
-
Couldn't load subscription status.
- Fork 44
Separate and simplify PyDis specific usage #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jb3
wants to merge
10
commits into
main
Choose a base branch
from
jb3/pydis-version-separation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+130
−114
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
467dd4e
Split additional versions into new Dockerfile
jb3 74d6199
Update dependencies
jb3 641ebbc
Build and use integration image for testing
jb3 008336f
Use pydis build for Docker compose
jb3 fda4014
Build and use PyDis image when deploying to Kubernetes
jb3 a0bf859
Add local registry for sharing between buildx jobs
jb3 3711f92
Update argparse usage to support 3.14
jb3 51f9b1c
Handle memory OOMs instead of process kills
jb3 8f77899
Use local registry for final deploy stage
jb3 d08f0bc
Document additional interpreters
jb3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # This is a custom additional build of Snekbox that includes multiple Python versions. | ||
|
|
||
| # The Python versions are now pulled from pre-built images to reduce build time | ||
| # and complexity. The images are built in the python-builds repository. | ||
|
|
||
| ARG SNEKBOX_IMAGE=ghcr.io/python-discord/snekbox:latest | ||
| FROM ${SNEKBOX_IMAGE} | ||
|
|
||
| COPY --link --from=ghcr.io/python-discord/python-builds:3.13 /snekbin/ /snekbin/ | ||
| COPY --link --from=ghcr.io/python-discord/python-builds:3.14 /snekbin/ /snekbin/ | ||
| COPY --link --from=ghcr.io/python-discord/python-builds:3.14t /snekbin/ /snekbin/ | ||
| COPY --link --from=ghcr.io/python-discord/python-builds:3.14j /snekbin/ /snekbin/ | ||
|
|
||
| RUN rm /snekbin/python/default && ln -s /snekbin/python/3.14/ /snekbin/python/default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of hosting a registry in our job?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a registry allows us to use the newly built
ghcr.io/python-discord/snekboximage for oursnekbox-pydisbuild (you will see later that images are pushed tolocalhost:5000).https://stackoverflow.com/a/63927832
There is probably some combination of cache-to/cache-from that may also work here but creating a local registry is a 3 second operation that then ensure we are using the right images and there will be no attempt made to pull images if the cache operations fail for whatever reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot that steps within the same job don't share the cache. But I thought that's what the existing cache-to/from already solve.