Remove css that collapses table #111
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If there are no objections I’d like to merge this promptly as it is a pretty big (visual) bug on small screens. |
|
I think expanded view is more convenient on mobile. I'd set overflow-x: auto on table rows, and omit languages without repositories in this view to solve the issue of collapsed rows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks distorted (i.e., overflowing text, misaligned text, unexpected artifacts, etc.), I think that just making it scroll-able is much nicer, and simpler.
Before
📊 Dashboard preview 📊: https://python-docs-translations.github.io/dashboard/111/merge/